Improve import and export parsing with babel #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
johno
requested review from
wooorm,
silvenon,
ChristopherBiscardi and
timneutkens
wooorm
reviewed
Feb 12, 2019
ChristopherBiscardi
approved these changes
Feb 14, 2019
In order to maintain positional metadata for AST nodes that are parsed, we need to ensure that each import/export is eaten in order as a correct subvalue. Since the remark eat function requires the string to be consumed in order, with no missing characters, the babel plugin now returns the start value which is used to sort the nodes and partition the input string. They're then combined again and returned as nodes that can be eaten in order by the tokenizer. This also comes with the benefit of no longer changing the input code which occurs with the prior babel generator.
Closed
wooorm
requested changes
Feb 14, 2019
|
Good calls @wooorm. Addressed in latest commits. |
johno
added a commit
that referenced
this pull request
Feb 18, 2019
* Improve import and export parsing with babel This introduces babel for better handling import and export parsing. Anything that is an import/export block will be parsed by babel and split up ensuring that edge cases will no longer occur based on how the JS is grouped. It also makes parsing the export default nodes more robust. - #345 - #340 * Add multiline fixtures * Preserve positional information for AST nodes In order to maintain positional metadata for AST nodes that are parsed, we need to ensure that each import/export is eaten in order as a correct subvalue. Since the remark eat function requires the string to be consumed in order, with no missing characters, the babel plugin now returns the start value which is used to sort the nodes and partition the input string. They're then combined again and returned as nodes that can be eaten in order by the tokenizer. This also comes with the benefit of no longer changing the input code which occurs with the prior babel generator. * Remove unneeded babel generator dep * Simplify partition function * Make naming consistent * Add snapshot test to verify positional info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces babel for better handling import and
export parsing. Anything that is an import/export block
will be parsed by babel and split up ensuring that
edge cases will no longer occur based on how the
JS is grouped. It also makes parsing the export default
nodes more robust.