Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LittleFS and FatFS choice on drop-down #23

Closed
wants to merge 28 commits into from
Closed

Added LittleFS and FatFS choice on drop-down #23

wants to merge 28 commits into from

Conversation

lorol
Copy link

@lorol lorol commented Jun 19, 2020 •
edited
Loading

If you ever want to have this hack to add LittleFS and FatFS choice to the original tool made only for SPIFFS ... please consider this PR

@lorol lorol mentioned this pull request Jun 24, 2020
Closed
@lorol lorol changed the title Added LittleFS choice Added LittleFS and FatFS choice on drop-down Jul 14, 2020
@lorol
Copy link
Author

lorol commented Jul 14, 2020

Added FatFS,, mk...fs binaries and modified Update lib to work with all three filesystems through serial port and ota.

lorol and others added 15 commits July 14, 2020 14:52
@lorol
Release 2.0.1
d4c0f00 
Added checkup of partition scheme vs. chosen filesystem
Typo error fixes and minor changes
@lorol
Updated README.md
97143d0
@lorol
Updated README.md and added a snapshot
b51ef07
@lorol
Change first choice (default) of drop-down to LittleFS
fee9640
@lorol
Added a choice to "Erase All Flash" at the end of FS type selections
9efcdb7 
Updated assets
@steph-prv
add support to esp32s2
aaa5335
@zouffin
Merge branch 'master' into fix_merge
eeb21f3
@lorol
Merge branch 'zouffin-fix_merge'
4651830
@lorol
Added messages to console about chip type
92b4956 
Modified README
@lorol
Use partitions.csv from sketch folder
0e20b77
@lorol
Calculating the missing Offset (begining of partition) of partition.c…
83a0e1a 
…sv file lines.

Minor changes in make.win batch file
@lorol
Parse partition csv file line' Offset(Start address) and Size values
cd75923 
containing 0x 0X hexadecimal or M,m,K,k bytes as described in
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/partition-tables.html#offset-size
Similarily to gen_esp32part.py
@lorol
Improvements and tests before release
810d85c
@lorol
Release 2.0.5 with comment how to build a jar that is in esp32fs_no_c…
22efec6 
…ompress.zip variant
@lorol
jar files added to .gitignore
a41ef5c
@lbernstone
Copy link

This either needs to be merged, or forked into its own project, as there are a number of issues being reported that won't apply to @me-no-dev's version.

@lorol
Copy link
Author

lorol commented Dec 9, 2020 •
edited
Loading

@lbernstone
I really added stuff after that request to resolve my needs, and built it in a dummy way w/o any planned and tested approach by different hosts and so on.
If you'd like to re-develop it in a proper way - please do it.
Especially FFat part - it is based on your ideas and the counterpart mk binaries can be linked from original repositories.

Otherwise, I don't know what to do with merging to the original. It looks like it is mergeable.

I guess the merge itself can be done only by the authorized people?

lorol
lorol commented Dec 11, 2020
View reviewed changes
Copy link
Author

@lorol lorol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added LittleFS and FFat choices as well as "erase all" choices to the original SPIFFS tool.
Also if partitions.csv is present at sketch folder it will be used instead of IDE selection.

@lbernstone
Copy link

Can you separate out the bits that are absolutely needed to support the esp32s2 and submit those as a separate PR? That is what really needs to make it back upstream.

@lorol
Copy link
Author

lorol commented Dec 12, 2020 •
edited
Loading

@lbernstone
In this case it is best to ask @zouffin the author of this addition to PR directly at upstream repository.
See here how the story started:
lorol#2
And I do not have s2 device to test.

lorol and others added 6 commits December 15, 2020 12:53
@lorol
Copy link
Author

lorol commented Dec 24, 2020 •
edited
Loading

Agree with @lbernstone for more conservative PR approach with fewer changes at a time, starting by most important ones.
Maybe later will PR again.
For now, I continue with the fork here: https://github.com/lorol/arduino-esp32fs-plugin

@lorol lorol closed this Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lorol @lbernstone @me-no-dev @steph-prv @zouffin