[main] Fix version string generation #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll just wait a day or two to see if people are reporting nasty problems and switch back to "normal" mode
|
eumagga0x2a
force-pushed
the
adm-version-print
branch
from
d441da0
to
706f1c9
Compare
|
There is no urge :-) I've deleted the second commit in this PR, the patch there worked, but the approach was wrong. It looks like the current ADM code confuses unsetting a variable ( |
…generation for jobs
|
The new version of the second patch unifies the logic of the version string generation (developer build vs. release) and takes care about more places in the tree. |
|
Oops, did you mean that I should have merged these patches into the "support" branch first? |
|
No, support is for emergency fix on 2.6.19
…On Thu, Mar 30, 2017 at 2:06 PM, eumagga0x2a ***@***.***> wrote:
Oops, did you mean that I should have merged these patches into the
"support" branch first?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#137 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AICVnS7PO_uLE59K9xiMg_ehcJjcNCnmks5rq5qrgaJpZM4MsqBm>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would restrain from pushing even trivial changes on my own while in release mode. This too-late-patch fixes the version string generation for the Avidemux log header.