[flyDialog] Fix navigation slider (WIP), add missing tooltips #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should fix wrong scaling by setting maximum value for the slider straight away in the constructor and make the slider approximately reflect the current position, albeit not during playback. It also adds missing tooltips to the navigation buttons.
There is a not yet understood disagreement between the slider value from
sliderGetimmediately after drag and afternextImage, the slider jumps slightly backwards.The total duration accessed as
_in->getInfo()->totalDurationis not updated if the changeFps filter is added. This might be an issue with underlying code and not the preview dialog's fault.