This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Task Enhancements #666
Merged
Task Enhancements #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need someone who knows gulp to review this |
| @@ -32,7 +33,7 @@ gulp.task('nodemon', function () { | |||
| script: 'server.js', | |||
| nodeArgs: ['--debug'], | |||
| ext: 'js,html', | |||
| watch: _.union(defaultAssets.server.views, defaultAssets.server.allJS, defaultAssets.server.config) | |||
| watch: _.union(defaultAssets.server.gulpConfig, defaultAssets.server.views, defaultAssets.server.allJS, defaultAssets.server.config) | |||
There was a problem hiding this comment.
Does Gulp work with new code if you have it watching? I don't remember it being able to do that..
rhutchison
force-pushed
the
task-enhancements
branch
3 times, most recently
from
87e65b2 to
7feae10
Compare
remove watch on gulpfile.js
rhutchison
force-pushed
the
task-enhancements
branch
from
7feae10 to
3e378b4
Compare
|
@ilanbiala please review updated PR. |
| .pipe(plugins.rename(function (path) { | ||
| path.dirname = path.dirname.replace('/scss', '/css'); | ||
| .pipe(plugins.rename(function (file) { | ||
| file.dirname = file.dirname.replace(path.sep + 'scss', path.sep + 'css'); |
There was a problem hiding this comment.
Sorry, I meant into Gulp. Also, how is it path.sep when we are passing in file now?
There was a problem hiding this comment.
file is just an object with dirname, which is the directory of which the file belongs to. I am missing your questions.
There was a problem hiding this comment.
|
@lirantal LGTM. Any concerns, or can I merge? |
|
Go ahead, I don't know gulp yet anyway :-) |
ilanbiala
added a commit
that referenced
this pull request
Jul 24, 2015
Grunt and Gulp task enhancements
This was referenced Aug 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Grunt vs Gulp
If you are running gulp, and edit the gruntconfig.js file, gulp will restart. This change is to separate automation configuration changes so that gruntfile.js updates do not restart the gulp process.
Additionally, this adds gulpconfig.js monitoring so that it will restart gulp if there are changes to gulpconfig.js
Bug: Path Separator
There is an issue on windows with path separator when compiling less/sass with gulp. Grunt does not have this issue.