Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught 'config.qrbox' dimensions values should not be greater than the width of the HTML element. #357

Closed
cungikawake opened this issue Nov 26, 2021 · 3 comments · Fixed by #371
Closed

Uncaught 'config.qrbox' dimensions values should not be greater than the width of the HTML element. #357

cungikawake opened this issue Nov 26, 2021 · 3 comments · Fixed by #371
Assignees
@mebjas
Labels
fix-in-PR

Comments

@cungikawake
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.
@mebjas
Copy link
Owner

mebjas commented Dec 2, 2021

What is the device display width and what is the value of config.qrbox in your example?

@mebjas
Copy link
Owner

mebjas commented Dec 12, 2021

@cungikawake gentle reminder to provide more context into this issue.

@mebjas
Copy link
Owner

mebjas commented Dec 20, 2021

I can reproduce this issue. So far it's an expected behavior.

Starting v2.1.5 this shall be replaced with throwing a warning and truncating the qrbox.width to the size of the root element.

@mebjas mebjas assigned mebjas and unassigned cungikawake Dec 20, 2021
mebjas added a commit that referenced this issue Dec 20, 2021
@mebjas
Version 2.1.5
4616fca 
### Changelog

 - Changed behavior from throwing error in case `qrbox.width` or `qrbox` is larger
    than the width of the root element. In such cases the dimension will automatically
    be truncated to the size of root element and will throw a warning based on verbosity
    settings. This should address [issue#357](#357)
@mebjas mebjas mentioned this issue Dec 20, 2021
Merged
mebjas added a commit that referenced this issue Dec 20, 2021
@mebjas
Version 2.1.5 (#371)
e2c0501 
* Version 2.1.5

### Changelog

 - Changed behavior from throwing error in case `qrbox.width` or `qrbox` is larger
    than the width of the root element. In such cases the dimension will automatically
    be truncated to the size of root element and will throw a warning based on verbosity
    settings. This should address [issue#357](#357)

* Fix error when qrbox size is not set.

* fix codacy error

* Calling Html5QrcodeScanner#clear() will clear the entire UI

Calling `Html5QrcodeScanner#clear()` will also clear the UI rendered due to image based scan. This should address [issue#193](#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mebjas mebjas

Labels
fix-in-PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 2.1.5 mebjas/html5-qrcode
2 participants
@mebjas @cungikawake