Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typings for EventHandler #14

Closed
flut1 opened this issue Feb 2, 2019 · 0 comments
Closed

Fix typings for EventHandler #14

flut1 opened this issue Feb 2, 2019 · 0 comments
Assignees
@flut1
Labels
bug

Comments

@flut1
Copy link
Contributor

flut1 commented Feb 2, 2019

The event parameter shouldn't be optional, as it's always provided by the EventDispatcher. Setting it optional adds an unnecessary requirement for event handlers to handle undefined as the event argument.
@flut1 flut1 self-assigned this Feb 2, 2019
@flut1 flut1 added the bug label Feb 2, 2019
@flut1 flut1 mentioned this issue Feb 7, 2019
Merged
@flut1 flut1 closed this as completed in #16 Feb 7, 2019
flut1 added a commit that referenced this issue Feb 7, 2019
@flut1
Release 1.2.4
727b8c9 
Includes fix for #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flut1 flut1

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flut1