Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flavor for CHIS Nepal (NSSD project) #229

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Add flavor for CHIS Nepal (NSSD project) #229

merged 4 commits into from
Nov 24, 2021

Conversation

binokaryg
Copy link
Member

@binokaryg binokaryg commented Nov 18, 2021 •
edited
Loading

#231
Flavor for:
Community Health Information System
NSSD, Department of Health Services,
Ministry of Health, Nepal

Name: CHIS
URL: https://chis.dohs.gov.np

@binokaryg binokaryg changed the title Add APK for CHIS Nepal (NSSD project) Add flavor for CHIS Nepal (NSSD project) Nov 18, 2021
@binokaryg binokaryg marked this pull request as draft November 19, 2021 08:32
@binokaryg
CHIS Nepal (NSSD):
c54d23c 
Adding encrypted keys
Adding tasks to publish.yml
@binokaryg binokaryg marked this pull request as ready for review November 20, 2021 13:44
@binokaryg binokaryg mentioned this pull request Nov 23, 2021
Closed
6 tasks
@binokaryg binokaryg linked an issue Nov 23, 2021 that may be closed by this pull request
New branded App NSSD MoH Nepal - "CHIS" #231
Closed
6 tasks
@binokaryg binokaryg removed a link to an issue Nov 23, 2021
New branded App NSSD MoH Nepal - "CHIS" #231
Closed
6 tasks
mrsarm
mrsarm suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@mrsarm mrsarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Everything looks great, except for minor request changes added.

src/chis_ne/res/mipmap-anydpi-v26/ic_launcher.xml Outdated Show resolved Hide resolved
src/chis_ne/res/mipmap-anydpi-v26/ic_launcher_round.xml Outdated Show resolved Hide resolved
src/chis_ne/res/values/ic_launcher_background.xml Outdated Show resolved Hide resolved
src/chis_ne/res/values/strings.xml Outdated Show resolved Hide resolved
@binokaryg
Address feedback from PR review #229:
cd04dc8 
- Added new lines
- Changed the app name to shorter version
@binokaryg
Copy link
Member Author

Confirmed with @garethbowen that the environment variables have been added.

@binokaryg binokaryg merged commit 21fc2c3 into master Nov 24, 2021
@mrsarm mrsarm deleted the nssd-ne branch December 1, 2021 18:05
@jkuester jkuester added this to the 0.11.0 milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsarm mrsarm mrsarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@binokaryg @mrsarm @jkuester