-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medic conf actions tests #7073
Medic conf actions tests #7073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I added a couple of recommendation inline, but nothing major.
I think this is very useful to have here, thanks a lot for adding it.
Ideally we should also have something similar in medic-conf
and run it against the current working branch of medic-conf.
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
True. We need to find ways to run this in |
To be discussed - how to include similar tests in medic-conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I only have one pending request, that was skipped in the previous review.
Could you please rebase off of master to fix the conflicts. Thanks!
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! It's great to have these tests!
Description
Testing major medic conf actions
medic/medic-release-testing# 83
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.