Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medic conf actions tests #7073

Merged
merged 16 commits into from
May 8, 2021
Merged

Medic conf actions tests #7073

merged 16 commits into from
May 8, 2021

Conversation

ngaruko
Copy link
Contributor

@ngaruko ngaruko commented Apr 23, 2021

Description

Testing major medic conf actions
medic/medic-release-testing# 83

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@ngaruko ngaruko marked this pull request as ready for review April 27, 2021 19:48
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I added a couple of recommendation inline, but nothing major.

I think this is very useful to have here, thanks a lot for adding it.
Ideally we should also have something similar in medic-conf and run it against the current working branch of medic-conf.

tests/medic-conf/medic-conf-actions.spec.js Outdated Show resolved Hide resolved
tests/medic-conf/medic-conf-actions.spec.js Outdated Show resolved Hide resolved
tests/medic-conf/medic-conf-actions.spec.js Outdated Show resolved Hide resolved
tests/medic-conf/medic-conf-actions.spec.js Outdated Show resolved Hide resolved
tests/medic-conf/medic-conf-actions.spec.js Outdated Show resolved Hide resolved
tests/medic-conf/medic-conf-actions.spec.js Outdated Show resolved Hide resolved
ngaruko and others added 5 commits April 29, 2021 11:30
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
@ngaruko
Copy link
Contributor Author

ngaruko commented May 1, 2021

Nice work!
I added a couple of recommendation inline, but nothing major.

I think this is very useful to have here, thanks a lot for adding it.
Ideally we should also have something similar in medic-conf and run it against the current working branch of medic-conf.

True. We need to find ways to run this in medic-conf. Not as easy as here as we need the required files and folders in medic-conf - and an instance to point to (or boot up cht-core in medic-conf)

@ngaruko ngaruko dismissed dianabarsan’s stale review May 1, 2021 07:28

To be discussed - how to include similar tests in medic-conf

Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I only have one pending request, that was skipped in the previous review.

Could you please rebase off of master to fix the conflicts. Thanks!

tests/medic-conf/medic-conf-actions.spec.js Show resolved Hide resolved
@ngaruko ngaruko requested a review from dianabarsan May 7, 2021 01:19
Co-authored-by: Diana Barsan <35681649+dianabarsan@users.noreply.github.com>
@ngaruko ngaruko requested review from dianabarsan and removed request for newtewt May 7, 2021 23:00
Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! It's great to have these tests!

@dianabarsan dianabarsan merged commit 1c3c278 into master May 8, 2021
@dianabarsan dianabarsan deleted the medic-conf-actions-tests branch May 8, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants