80-Test for Search functionality #7225
Conversation
| @@ -49,6 +49,10 @@ describe('Create Person Under Area', async () => { | |||
| await loginPage.cookieLogin(); | |||
| }); | |||
|
|
|||
| afterEach(async () => { | |||
| await utils.revertDb([], true); | |||
There was a problem hiding this comment.
We are planning of using these in wdi hooks. We seem to use it in every spec
There was a problem hiding this comment.
Sure I guess we can keep it for now and when we add it in the hooks, we can come back and remove it. Does it make sense?
| const commonPage = require('../../page-objects/common/common.wdio.page'); | ||
| const placeFactory = require('../../factories/cht/contacts/place'); | ||
| const personFactory = require('../../factories/cht/contacts/person'); | ||
| const places = placeFactory.generateHierarchy(); // This generates ['district_hospital', 'health_center', 'clinic'] |
There was a problem hiding this comment.
Maybe you did not need to comment on this?
| const moment = require('moment'); | ||
| const placeFactory = require('../../factories/cht/contacts/place'); | ||
| const personFactory = require('../../factories/cht/contacts/person'); | ||
| const places = placeFactory.generateHierarchy(); // This generates ['district_hospital', 'health_center', 'clinic'] |
There was a problem hiding this comment.
same here, about the comment?
| await (await searchIcon()).click(); | ||
| // After the button is pressed there can be a slight delay before the AJAX call | ||
| // is made and the search spinner shows up hence we just need to wait for a bit before moving forward | ||
| await browser.pause(1000); |
There was a problem hiding this comment.
We normally try to avoid random wait/pause but rather be specific on what we want to wait for. Maybe someElement.waitForDisplayed({}), which can also be used for wait for element to disappear with `r{everse:true}'?
There was a problem hiding this comment.
I feel using a fixed wait time here actually makes sense because this wait is not dependent on any network call, it's just to make sure that after we click, we give enough time for the search AJAX call to trigger. Maybe waiting on spinner will make it more complex. Thoughts?
There was a problem hiding this comment.
I think if it is the spinner we are waiting to disappear we could use that. $('.loader')); which we probably need to do in many other areas, thus might need a sort of utility function for that. But not a biggie, so feel free to merge.
| await (await clearContacts()).click(); | ||
| // After the button is pressed there can be a slight delay before the AJAX call | ||
| // is made and the search spinner shows up hence we just need to wait for a bit before moving forward | ||
| await browser.pause(1000); |
There was a problem hiding this comment.
same here, the random pause
Description
Test the Search Functionality
medic/cht-core#[80]
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.