-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9116): update user place field in admin to allow setting multiple places #9128
Conversation
a50f55f
to
94fb460
Compare
@Benmuiruri, this is just a reminder to please enable the test |
66c1166
to
7f86ea5
Compare
114252d
to
da011a6
Compare
9293711
to
c1dd63f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All AC's in the description look good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff! Great work!
I left some comments mostly about readability and reusability.
da011a6
to
03c645a
Compare
Hi @dianabarsan I have made almost all of the requested changes. The one I could not figure out is the suggestion to use |
03c645a
to
d2abe9b
Compare
9c72aa4
to
43a970b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Some minor things inline to unblock you. I'll give this a try tomorrow!
20ae761
to
26cc25b
Compare
feded91
to
627c2b6
Compare
This reverts commit d9b1cff.
12eeb56
to
2d6e651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I left one minor comment about unit test coverage.
Description
This is a continuation of #6543
Now, users can be associated with more than one facility. This PR enables the CHT's Admin app to provide a way to associate those facilities with the user.
To get the feature to work, the admin user must enable
can_have_multiple_places
to some specific roles (e.g Supervisor, community_health_assistant, etc)Whenever a new user is added:
can_have_multiple_places
Closes #9116
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.