Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#9187): fix haproxy version to 2.6.17 #9188

Merged
merged 4 commits into from
Jun 19, 2024
Merged

fix(#9187): fix haproxy version to 2.6.17 #9188

merged 4 commits into from
Jun 19, 2024

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Jun 19, 2024 •
edited by github-actions bot
Loading

Description

Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan
log request output
91f7a82 
Signed-off-by: Diana Barsan <barsan@medic.org>
@dianabarsan
log request output
845ff13 
Signed-off-by: Diana Barsan <barsan@medic.org>
@dianabarsan
log request output
5622eb0 
Signed-off-by: Diana Barsan <barsan@medic.org>
@dianabarsan
fix haproxy version to 2.6.17
eaf5a4d 
Signed-off-by: Diana Barsan <barsan@medic.org>
latin-panda
latin-panda approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dianabarsan dianabarsan removed the request for review from sugat009 June 19, 2024 14:04
@dianabarsan dianabarsan merged commit 020c3c3 into master Jun 19, 2024
41 checks passed
@dianabarsan dianabarsan deleted the 9187-fix-haproxy-test branch June 19, 2024 14:47
dianabarsan added a commit that referenced this pull request Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17 (#9188)
5842470 
Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187

(cherry picked from commit 020c3c3)
dianabarsan added a commit that referenced this pull request Jun 19, 2024
@dianabarsan
fix(#9187): fix haproxy version to 2.6.17 (#9188)
6f3ee09 
Haproxy published a new 2.6.18 image today, which breaks one of our unit tests. It might also break behavior.
Fixing the image version to 2.6.17 resolves the issue and makes sure we're having expected behavior.

#9187

(cherry picked from commit 020c3c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latin-panda latin-panda latin-panda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dianabarsan @latin-panda