Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Bundle.relation.next link when using iterated includes #4147

Closed
rahul1 opened this issue Mar 11, 2024 · 0 comments · Fixed by #4621
Closed

Invalid Bundle.relation.next link when using iterated includes #4147

rahul1 opened this issue Mar 11, 2024 · 0 comments · Fixed by #4621
Assignees
@codyebberson
Labels
bug Something isn't working search Features and fixes related to search
Milestone
June 30, 2024

Comments

@rahul1
Copy link
Member

rahul1 commented Mar 11, 2024

Repro

    for await (const resources of this.medplumAdmin.searchResourcePages('ProjectMembership', {
      'profile-type': 'Practitioner',
      _include: 'ProjectMembership:profile',
      '_revinclude:iterate': 'PractitionerRole:practitioner',
      _count: 5,
    })) {

The first result set contains all the resources I would expect.
However, I notice that the bundle link for the next page shows this:

https://api.medplum.com/fhir/R4/ProjectMembership?_count=5&_include=ProjectMembership:profile&_offset=5&_revinclude=PractitionerRole:practitioner&profile-type=Practitioner

Notice that _revinclude does not have the :iterate modifier.
@rahul1 rahul1 added bug Something isn't working search Features and fixes related to search labels Mar 11, 2024
@rahul1 rahul1 added this to the April 30th, 2024 milestone Mar 27, 2024
codyebberson added a commit that referenced this issue May 30, 2024
@codyebberson
Fixes #4147 - formatSearchQuery with _include:iterate
79dec63
github-merge-queue bot pushed a commit that referenced this issue May 31, 2024
@codyebberson
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
c53aa6e
@reshmakh reshmakh modified the milestones: May 31st, 2024, June 30, 2024 Jun 2, 2024
medplumbot added a commit that referenced this issue Jun 2, 2024
@medplumbot
Release Version 3.1.7
4435394 
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
@medplumbot medplumbot mentioned this issue Jun 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 2, 2024
@medplumbot
Release Version 3.1.7 (#4621)
5fa9071 
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyebberson codyebberson

Labels
bug Something isn't working search Features and fixes related to search
Projects
Medplum Product Roadmap
Status: ✅ Done
Milestone
June 30, 2024
Development

Successfully merging a pull request may close this issue.

Release Version 3.1.7 medplum/medplum
3 participants
@codyebberson @rahul1 @reshmakh