Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nested transactions with stronger isolation #4583

Merged
merged 7 commits into from
May 29, 2024

Conversation

mattwiller
Copy link
Member

This PR un-reverts #3866 and adds some fixes, plus hardcodes the transaction isolation level to repeatable read, which prevents against concurrent modifications.

We should merge this ahead of both #4358 and #4558

@mattwiller mattwiller added the fhir-datastore Related to the FHIR datastore, includes API and FHIR operations label May 22, 2024
@mattwiller mattwiller added this to the May 31st, 2024 milestone May 22, 2024
@mattwiller mattwiller self-assigned this May 22, 2024
@mattwiller mattwiller requested a review from a team as a code owner May 22, 2024 23:00
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 11:51pm
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 11:51pm
medplum-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 11:51pm
medplum-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 11:51pm

Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

I added a small suggestion to Repository.close(), w.r.t. purging bad connections. Your call.

packages/server/src/fhir/repo.ts Outdated Show resolved Hide resolved
Co-authored-by: Cody Ebberson <cody@ebberson.com>
Copy link

sonarcloud bot commented May 29, 2024

@mattwiller mattwiller added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit a581085 May 29, 2024
32 checks passed
@mattwiller mattwiller deleted the full-nested-transactions branch May 29, 2024 17:56
medplumbot added a commit that referenced this pull request Jun 2, 2024
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
@medplumbot medplumbot mentioned this pull request Jun 2, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 2, 2024
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fhir-datastore Related to the FHIR datastore, includes API and FHIR operations
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants