Fix several fhirpath functions taking other Atom and implement subsetOf & supersetOf
#4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codyebberson
approved these changes
May 28, 2024
mattlong
force-pushed
the
fhirpath-other-functions
branch
from
a7fe77b
to
ab667a4
Compare
|
reshmakh
added
the
fhir-datastore
medplumbot
added a commit
that referenced
this pull request
Jun 2, 2024
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593) feat: enable unit testing subscription criteria (#4581) feat(fhircast): properly respond to `unsubscribe` request (#4590) Fixes #4576 - Windows 1252 character encoding (#4594) refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585) Added fhirpath test data (#4598) Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601) Use nested transactions with stronger isolation (#4583) Support Database SSL config from Env (#4597) Parse ADT example (#4596) Better PATCH error messages (#4607) Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588) Fix IAM policy resource strings (#4603) Fixes #4440 - backslash escaped commas in search values (#4609) Fixes #4147 - formatSearchQuery with _include:iterate (#4610) Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612) Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611) Allow Bot to return Binary (#4595) Remove spurious console.warn (#4616) Fixed flaky repo tests (#4618) Fixes #4617 - replace Google QR code API (#4619)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 2, 2024
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593) feat: enable unit testing subscription criteria (#4581) feat(fhircast): properly respond to `unsubscribe` request (#4590) Fixes #4576 - Windows 1252 character encoding (#4594) refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585) Added fhirpath test data (#4598) Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601) Use nested transactions with stronger isolation (#4583) Support Database SSL config from Env (#4597) Parse ADT example (#4596) Better PATCH error messages (#4607) Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588) Fix IAM policy resource strings (#4603) Fixes #4440 - backslash escaped commas in search values (#4609) Fixes #4147 - formatSearchQuery with _include:iterate (#4610) Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612) Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611) Allow Bot to return Binary (#4595) Remove spurious console.warn (#4616) Fixed flaky repo tests (#4618) Fixes #4617 - replace Google QR code API (#4619)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a tangentially related project, I discovered that the fhirpath function implementation taking an
othercollection parameter were implemented incorrectly: evaluating the other expression against the currentinputvalue rather than the original/"root" input.This PR undoes some of the changes in #4189 to get proper resolution of
$thiswithout having to explicitly modify the context before each call to.eval(...)which would be rather tedious. @codyebberson, was there a reason for those changes that I'm missing?