Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse ADT example #4596

Merged
merged 3 commits into from
May 30, 2024
Merged

Parse ADT example #4596

merged 3 commits into from
May 30, 2024

Conversation

reshmakh
Copy link
Member

Proposed for #4489

@reshmakh reshmakh self-assigned this May 27, 2024
@reshmakh reshmakh requested a review from a team as a code owner May 27, 2024 18:49
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 4:15pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-app ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 4:15pm
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 4:15pm
medplum-www ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 4:15pm

Copy link
Member

@codyebberson codyebberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, overall looks good. A bunch of minor stuff, but feel free to ignore.

Some of these would make great HL7 helpers in @medplum/core, such as PID-to-Patient. For future consideration

Comment on lines 8 to 9
//To run these tests from the command line
//npm t src/adt-transfer-listener/adt-transfer-bot.test.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//To run these tests from the command line
//npm t src/adt-transfer-listener/adt-transfer-bot.test.ts
// To run these tests from the command line
// npm t src/adt-transfer-listener/adt-transfer-bot.test.ts

return input.buildAck();
}

//Only supported message types should be processed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//Only supported message types should be processed
// Only supported message types should be processed

import { BotEvent, Hl7Message, MedplumClient } from '@medplum/core';
import { Encounter, Patient } from '@medplum/fhirtypes';

export async function handler(medplum: MedplumClient, event: BotEvent): Promise<Hl7Message> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export async function handler(medplum: MedplumClient, event: BotEvent): Promise<Hl7Message> {
export async function handler(medplum: MedplumClient, event: BotEvent<Hl7Message>): Promise<Hl7Message> {

import { Encounter, Patient } from '@medplum/fhirtypes';

export async function handler(medplum: MedplumClient, event: BotEvent): Promise<Hl7Message> {
const input = event.input as Hl7Message;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const input = event.input as Hl7Message;
const input = event.input;

@reshmakh
Copy link
Member Author

Created helper task for PID to Patient for review/feedback #4599

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@reshmakh reshmakh added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 29, 2024
@reshmakh reshmakh added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit d69e02c May 30, 2024
32 checks passed
@reshmakh reshmakh deleted the reshma-adt-transfer branch May 30, 2024 00:25
medplumbot added a commit that referenced this pull request Jun 2, 2024
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
@medplumbot medplumbot mentioned this pull request Jun 2, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 2, 2024
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants