Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4576 - Windows 1252 character encoding #4594

Merged
merged 3 commits into from
May 27, 2024
Merged

Fixes #4576 - Windows 1252 character encoding #4594

merged 3 commits into from
May 27, 2024

Conversation

codyebberson
Copy link
Member

@codyebberson codyebberson commented May 27, 2024 •
edited
Loading

  • packages/hl7
    • Replaced the encoding: BufferEncoding param with encoding: string
    • Before, the BufferEncoding was passed to the Node.js socket setEncoding and defaulted to UTF-8
    • After, the Node.js socket never calls setEncoding and relies on Buffer for everything
    • We encode/decode all data with iconv-lite
    • We still default to UTF-8 if encoding is not specified
  • packages/agent
    • For HL7 listener, we use the encoding from the encoding query param in Endpoint.address
    • For HL7 push, we use the encoding from the encoding query param in Device.url
    • For example, mllp://localhost:2575?encoding=windows-1252
  • packages/cli
    • Added a new optional --encoding argument to medplum hl7 listen
    • Added a new optional --encoding argument to medplum hl7 send

image

@codyebberson codyebberson requested a review from a team as a code owner May 27, 2024 17:39
@vercel Vercel
Copy link

vercel bot commented May 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medplum-provider ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 6:40pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
medplum-app ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 6:40pm
medplum-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 6:40pm
medplum-www ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 6:40pm

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ThatOneBro
ThatOneBro approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@ThatOneBro ThatOneBro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean. LGTM

@codyebberson codyebberson added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 2dcd87f May 27, 2024
32 checks passed
@codyebberson codyebberson deleted the cody-windows-1252 branch May 27, 2024 19:52
@ThatOneBro ThatOneBro mentioned this pull request May 28, 2024
Closed
@reshmakh reshmakh added this to the May 31st, 2024 milestone May 30, 2024
medplumbot added a commit that referenced this pull request Jun 2, 2024
@medplumbot
Release Version 3.1.7
4435394 
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
@medplumbot medplumbot mentioned this pull request Jun 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 2, 2024
@medplumbot
Release Version 3.1.7 (#4621)
5fa9071 
Updating sample HL7 bot to include ADT-08 messages (#4591)Dependency upgrades 2024-05-27 (#4593)
feat: enable unit testing subscription criteria (#4581)
feat(fhircast): properly respond to `unsubscribe` request (#4590)
Fixes #4576 - Windows 1252 character encoding (#4594)
refactor(subscriptions): skip `bullmq` for WS subs, push all WS subs thru one Redis channel (#4585)
Added fhirpath test data (#4598)
Fix several fhirpath functions taking `other` Atom and implement subsetOf & supersetOf (#4601)
Use nested transactions with stronger isolation (#4583)
Support Database SSL config from Env (#4597)
Parse ADT example  (#4596)
Better PATCH error messages (#4607)
Respect AccessPolicy.resource.{readonlyFields,hiddenFields} in ResourceForm (#4588)
Fix IAM policy resource strings (#4603)
Fixes #4440 - backslash escaped commas in search values (#4609)
Fixes #4147 - formatSearchQuery with _include:iterate (#4610)
Fixes #4462 - configurable Bot AuditEvent.outcomeDesc max length (#4612)
Fixes #4531 - choice-of-type definitions and getExtensionValue() (#4611)
Allow Bot to return Binary (#4595)
Remove spurious console.warn (#4616)
Fixed flaky repo tests (#4618)
Fixes #4617 - replace Google QR code API (#4619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatOneBro ThatOneBro ThatOneBro approved these changes

Assignees

@codyebberson codyebberson

Labels
integration
Projects
Medplum Product Roadmap
Status: ✅ Done
Milestone
May 31st, 2024
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codyebberson @ThatOneBro @reshmakh