Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): Partial module service implementation #6012

Merged
merged 15 commits into from
Jan 12, 2024

Conversation

olivermrbl
Copy link
Contributor

Awaiting #6000 #6008

What

  • CRUD for Address in Cart Module service
  • Tests for CRUD Carts + Address

Not

  • Line items, shipping methods, tax lines, adjustment lines

@olivermrbl olivermrbl requested a review from a team as a code owner January 7, 2024 12:06
Copy link

changeset-bot bot commented Jan 7, 2024

🦋 Changeset detected

Latest commit: 8fa6176

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/inventory Patch
@medusajs/stock-location Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 10:21am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 10:21am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 10:21am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 10:21am

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one todo 👍

packages/cart/src/models/cart.ts Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Show resolved Hide resolved
@olivermrbl olivermrbl changed the base branch from feat/cart-module-module-service-impl to feat/cart-module-partial January 10, 2024 19:04
@olivermrbl olivermrbl requested review from a team as code owners January 10, 2024 19:13
@adrien2p
Copy link
Member

Before running another review, could you handle the conflicts 👍

@olivermrbl olivermrbl force-pushed the feat/cart-module-partial branch 4 times, most recently from f2f851c to 88f32c0 Compare January 11, 2024 11:03
@olivermrbl olivermrbl changed the base branch from feat/cart-module-partial to develop January 11, 2024 14:49
@olivermrbl
Copy link
Contributor Author

@adrien2p, conflicts have been addressed, and it should be ready for review :)

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just questions 💪

packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 192bc33 into develop Jan 12, 2024
16 checks passed
@kodiakhq kodiakhq bot deleted the feat/cart-module-service branch January 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants