Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): Add CartService and AddressService #6008

Closed
wants to merge 61 commits into from

Conversation

olivermrbl
Copy link
Contributor

Awaiting #6000

What

  • CartService and CartRepository + tests
  • AddressService and AddressRepository + tests
  • CartModuleService skeleton. Full implementation + tests will be added in a separate PR

@olivermrbl olivermrbl requested a review from a team as a code owner January 6, 2024 13:43
Copy link

changeset-bot bot commented Jan 6, 2024

🦋 Changeset detected

Latest commit: 0224dab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/cart Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 1:22pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:22pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:22pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 1:22pm

@@ -1,20 +1,35 @@
import {
CartDTO,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment(this-file): WIP, do not review

@olivermrbl olivermrbl force-pushed the feat/cart-module-module-service-impl branch from e403a2c to 9523b91 Compare January 10, 2024 10:09
Base automatically changed from feat/cart-module-interface-types to develop January 10, 2024 12:28
@olivermrbl
Copy link
Contributor Author

Closing in favor of #6055

@olivermrbl olivermrbl closed this Jan 10, 2024
kodiakhq bot pushed a commit that referenced this pull request Jan 11, 2024
Duplicate of #6008, but I messed up my git history big time :'(

**What**
- CartService and CartRepository + tests
- AddressService and AddressRepository + tests
- CartModuleService skeleton. Full implementation + tests will be added in a separate PR
kodiakhq bot pushed a commit that referenced this pull request Jan 12, 2024
Awaiting #6000 #6008  

**What**
- CRUD for Address in Cart Module service
- Tests for CRUD Carts + Address

**Not**
- Line items, shipping methods, tax lines, adjustment lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants