Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart): Cart + Address services #6055

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Jan 10, 2024

Duplicate of #6008, but I messed up my git history big time :'(

What

  • CartService and CartRepository + tests
  • AddressService and AddressRepository + tests
  • CartModuleService skeleton. Full implementation + tests will be added in a separate PR

@olivermrbl olivermrbl requested a review from a team as a code owner January 10, 2024 19:00
Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: f318268

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 2:29pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 2:29pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 2:29pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 2:29pm

@olivermrbl
Copy link
Contributor Author

@adrien2p, OK to merge this? Duplicate PR was approved.

packages/cart/src/repositories/address.ts Show resolved Hide resolved
packages/cart/src/repositories/address.ts Outdated Show resolved Hide resolved
packages/cart/src/repositories/cart.ts Show resolved Hide resolved
packages/cart/src/services/address.ts Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Show resolved Hide resolved
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

.changeset/red-mirrors-tap.md Outdated Show resolved Hide resolved
packages/cart/src/services/cart-module.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart.ts Outdated Show resolved Hide resolved
packages/cart/src/services/cart.ts Outdated Show resolved Hide resolved
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/cart/src/repositories/address.ts Outdated Show resolved Hide resolved
packages/cart/src/repositories/cart.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants