Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add currency module and remove currency models from region and pricing modules #6536

Merged
merged 7 commits into from
Feb 29, 2024
Merged

feat: Add currency module and remove currency models from region and pricing modules #6536

merged 7 commits into from
Feb 29, 2024

Conversation

sradevski
Copy link
Member

What:

  • Creates a new currency module
  • Removes currency model from the pricing module
  • Removes currency model from region module

@sradevski sradevski requested review from a team as code owners February 28, 2024 14:42
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d18daac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Feb 29, 2024 2:38pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 2:38pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 2:38pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 2:38pm

sradevski
sradevski commented Feb 28, 2024
View reviewed changes
packages/currency/integration-tests/__tests__/currency-module-service.spec.ts Outdated
service,
}: SuiteOptions<ICurrencyModuleService>) => {
describe("Currency Module Service", () => {
// TODO: Remove this and load currencies in loader
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only todo that needs to be done before the PR is merged, but I decided to open it in a non-draft mode so others have the chance to review it in the meantime. The currencies will be loaded through a loader based on the final discussion we had with Adrien.

srindom
srindom previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srindom srindom dismissed their stale review February 29, 2024 12:36

missed migration issue

@sradevski
Copy link
Member Author

@srindom done!

riqwan
riqwan approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legend! 🔥

@kodiakhq kodiakhq bot merged commit dc02530 into develop Feb 29, 2024
17 checks passed
@sradevski sradevski deleted the feat/add-currency-module branch February 29, 2024 15:10
@kings-joy kings-joy mentioned this pull request Mar 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@riqwan riqwan riqwan approved these changes

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @riqwan @srindom