Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pricing): pricing models are made soft deletable #6732

Merged
merged 20 commits into from
Mar 20, 2024
Merged

feat(pricing): pricing models are made soft deletable #6732

merged 20 commits into from
Mar 20, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 18, 2024 •
edited
Loading

what:

  • pricing models are made soft deletable
  • adds missing timestamp attributes
  • removes unwanted relationships + cascade cleanup

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7c64ff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview Mar 20, 2024 3:30pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 3:30pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 3:30pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 3:30pm

@riqwan riqwan marked this pull request as ready for review March 18, 2024 18:03
@riqwan riqwan requested a review from a team as a code owner March 18, 2024 18:03
adrien2p
adrien2p reviewed Mar 19, 2024
View reviewed changes
packages/pricing/src/migrations/Migration20230929122253.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/money-amount.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/money-amount.ts Show resolved Hide resolved
packages/pricing/src/models/price-list-rule-value.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-list-rule.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-rule.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-list.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-set-money-amount.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-set-money-amount.ts Show resolved Hide resolved
@riqwan riqwan requested a review from adrien2p March 19, 2024 10:45
adrien2p
adrien2p reviewed Mar 20, 2024
View reviewed changes
packages/pricing/src/models/money-amount.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-list-rule-value.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-list-rule.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-list-rule.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-list-rule.ts Show resolved Hide resolved
packages/pricing/src/models/price-set-money-amount-rules.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-set-money-amount.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-set-rule-type.ts Outdated Show resolved Hide resolved
packages/pricing/src/models/price-set.ts Show resolved Hide resolved
packages/pricing/src/models/rule-type.ts Outdated Show resolved Hide resolved
@riqwan riqwan requested a review from adrien2p March 20, 2024 09:36
adrien2p
adrien2p approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

packages/pricing/src/models/money-amount.ts
serializer: Number,
})
amount: number | null
amount: number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should we use big numbers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I'll open a PR for this specifically.

@kodiakhq kodiakhq bot removed the automerge label Mar 20, 2024
@kodiakhq kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 20, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot merged commit 20243e2 into develop Mar 20, 2024
18 checks passed
@kodiakhq kodiakhq bot deleted the feat/pricing-soft-delete branch March 20, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @sradevski @adrien2p