Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fis(orchestration): Properly handle select all #6742

Merged
merged 8 commits into from
Mar 20, 2024
Merged

fis(orchestration): Properly handle select all #6742

merged 8 commits into from
Mar 20, 2024

Conversation

adrien2p
Copy link
Member

What
Fix select * without breaking select none []

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 709ae7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 11:38am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 20, 2024 11:38am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 11:38am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 11:38am

@adrien2p adrien2p marked this pull request as ready for review March 19, 2024 15:58
@adrien2p adrien2p requested review from a team as code owners March 19, 2024 15:58
sradevski
sradevski reviewed Mar 19, 2024
View reviewed changes
packages/modules-sdk/src/remote-query.ts Outdated Show resolved Hide resolved
packages/modules-sdk/src/remote-query.ts Outdated Show resolved Hide resolved
riqwan
riqwan approved these changes Mar 19, 2024
View reviewed changes
packages/modules-sdk/src/remote-query.ts Outdated Show resolved Hide resolved
.changeset/cold-mice-deliver.md Outdated Show resolved Hide resolved
olivermrbl
olivermrbl reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this fixes something, would it make sense to add a test to ensure it doesn't break again?

@kodiakhq kodiakhq bot merged commit 06f22bb into develop Mar 20, 2024
18 checks passed
@kodiakhq kodiakhq bot deleted the fix/remote-joiner branch March 20, 2024 12:10
This was referenced Mar 20, 2024
Merged
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riqwan riqwan riqwan approved these changes

@sradevski sradevski sradevski approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @sradevski @riqwan @olivermrbl