Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): migrate medusa unit tests / plugins integration tests to swc jest #6820

Merged
merged 29 commits into from
Mar 25, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 25, 2024

what:

  • migrates medusa package to swc/jest
  • migrates plugins integration tests to swc/jest
  • parallelises a few of the heavy test packages
  • fixes typeorm circular dependencies

Unit Tests

Before: 1 job => ~30 mins
After: 2 jobs => ~5 mins

Screenshot 2024-03-25 at 15 11 49

Plugins

Before: 1 job => ~10 mins
After: 1 job => ~5 mins

Screenshot 2024-03-25 at 15 26 03

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 360071d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 5:43pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Mar 25, 2024 5:43pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 5:43pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 5:43pm

@riqwan riqwan requested a review from a team as a code owner March 25, 2024 13:58
@carlos-r-l-rodrigues
Copy link
Contributor

  • Circular dependencies (typeorm relations)

I haven't checked the full PR yet, but if you solved circular dependencies, does that mean we can finally use ES6 (Es2020) everywhere, including /medusa?

@adrien2p
Copy link
Member

adrien2p commented Mar 25, 2024

@olivermrbl the issues was the circular dependencies that we postponed long time ago as well as using var that are not yet declared. This pr tackle it.

@carlos-r-l-rodrigues yes in theory we should be able to if the package doesn't have circular or use of variables that are declared later

Edit: just saw riqwan message

@kodiakhq kodiakhq bot merged commit 509ddf9 into develop Mar 25, 2024
24 checks passed
@riqwan riqwan deleted the feat/medusa-swc branch March 25, 2024 17:55
This was referenced Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants