Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard,medusa,fulfillment): Move Shipping Profiles to settings #7090

Merged
merged 6 commits into from
Apr 19, 2024
Merged

fix(dashboard,medusa,fulfillment): Move Shipping Profiles to settings #7090

merged 6 commits into from
Apr 19, 2024

Conversation

kasperkristensen
Copy link
Contributor

What

  • Moves Shipping Profiles to settings
  • Adds q and filters to shipping profile list endpoint
  • Adds new details page for profiles

@kasperkristensen kasperkristensen requested a review from a team as a code owner April 17, 2024 13:57
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd70cd9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 1:58pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Apr 19, 2024 1:58pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 1:58pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 1:58pm

sradevski
sradevski approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

...ashboard/src/v2-routes/shipping-profiles/shipping-profile-detail/shipping-profile-detail.tsx Outdated Show resolved Hide resolved
...hipping-profiles-list/components/shipping-profile-list-table/shipping-profile-list-table.tsx Outdated Show resolved Hide resolved
fPolic
fPolic approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit e2fabc1 into develop Apr 19, 2024
24 checks passed
@kodiakhq kodiakhq bot deleted the feat/shipping-profile-settings branch April 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@fPolic fPolic fPolic approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperkristensen @sradevski @fPolic