Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: install libnunit-cil-dev manually to fix build with new Mono #281

Merged
merged 3 commits into from
Jan 22, 2020

Conversation

knocte
Copy link
Contributor

@knocte knocte commented Jan 13, 2020

Newer versions of Mono such as 6.6.x don't provide NUnit anymore so the
package needs to be installed separately, otherwise the build fails like
it was happening for the master branch in its latest commit:

d4cfb71

Whose build log was:

https://travis-ci.org/meebey/smuxi/builds/627714687?utm_source=github_status&utm_medium=notification

@knocte knocte changed the base branch from master to stable January 13, 2020 14:47
Now that new versions of Mono such as 6.6.x don't bundle NUnit anymore,
we should check independently for it, otherwise the build might fail like
it was happening on the master branch:

meebey@d4cfb71

Whose build log was:

https://travis-ci.org/meebey/smuxi/builds/627714687?utm_source=github_status&utm_medium=notification
This should be the behaviour by default, but it seems Travis has not solved
this issue yet:
travis-ci/travis-ci#1066

Before this, it could happen that autogen.sh failed (because of some
missing dependency) but still try to build after that.
Newer versions of Mono such as 6.6.x don't provide NUnit anymore so the
package needs to be installed separately, otherwise the build fails like
it was happening for the master branch in its latest commit:

d4cfb71

Whose build log was:

https://travis-ci.org/meebey/smuxi/builds/627714687?utm_source=github_status&utm_medium=notification

A pkg-config check was also added in the configure script, here:
44ab327
@meebey meebey merged commit e9951f5 into meebey:stable Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants