Skip to content
This repository has been archived by the owner on Feb 22, 2019. It is now read-only.

more android XML changes #42

Merged
merged 2 commits into from
Jan 27, 2015
Merged

more android XML changes #42

merged 2 commits into from
Jan 27, 2015

Conversation

mlc
Copy link
Contributor

@mlc mlc commented Jan 26, 2015

This makes some good changes:

  • moves imports to the top of the build.rb like they belong
  • prefixes generated android color names with foundation_ so as not to conflict with existing colors
  • adds an XML comment with today's date
  • omits certain empty comment lines from the generated XML

And one pretty scary change:

  • uses a lower-level API to Psych, ruby's default YAML library, so that we can learn if a color entry is an alias or not. When it is an alias, use Android's resource aliasing feature instead of repeating the ARGB values in the output. This means that the YAML reading is now much more fragile with respect to structure changes or differences, and the ruby code is much more unreadable. But it works, so…

@akdetrick
Copy link
Contributor

this ruby was already somewhat unreadable

akdetrick added a commit that referenced this pull request Jan 27, 2015
@akdetrick akdetrick merged commit f284c3b into foundation Jan 27, 2015
@akdetrick akdetrick deleted the android_xml_changes_redux branch January 27, 2015 17:01
@mlc
Copy link
Contributor Author

mlc commented Jan 27, 2015

On 01/27/2015 12:01 PM, Adam Detrick wrote:

this ruby was already somewhat unreadable

you can count on me to finish the job!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants