Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN release for furrr #14

Closed
DavisVaughan opened this issue May 3, 2022 · 5 comments
Closed

CRAN release for furrr #14

DavisVaughan opened this issue May 3, 2022 · 5 comments

Comments

@DavisVaughan
Copy link

Hi there,

I have run revdeps for furrr and your package appeared in the checks.

It seems the CRAN version of your package still uses future_options(). This is now defunct in furrr.

I can see that you have removed it in favor of furrr_options() here, which is great!
dae31e3

You should also remove this @importFrom line here:

#' @importFrom furrr "future_options"

After you do that, is there any way you can submit simhelpers to CRAN very soon? The furrr release is otherwise ready to go.

Thanks!

@DavisVaughan
Copy link
Author

If you don't feel like you can get simhelpers out in 2 days or so, that's fine too! Just let me know and I will submit to CRAN anyways, and CRAN will give you a 2 week warning to submit a fix

@jepusto
Copy link
Collaborator

jepusto commented May 3, 2022 via email

@DavisVaughan
Copy link
Author

Thank you!

@jepusto jepusto closed this as completed in cd554c0 May 3, 2022
@jepusto
Copy link
Collaborator

jepusto commented May 3, 2022

Version 0.1.2 is on its way to CRAN.

@DavisVaughan
Copy link
Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants