Fix code-samples after #310 release #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
fix-code-samples
branch
from
1d1167d to
43028c8
Compare
ahmednfwela
reviewed
Jun 5, 2023
| faceted_search_2: |- | ||
| await client.multiSearch(MultiSearchQuery(queries: [ | ||
| SearchQuery( | ||
| IndexSearchQuery( |
There was a problem hiding this comment.
I think it's missing the query parameter
There was a problem hiding this comment.
Yep, I've opened an issue about it #321
There was a problem hiding this comment.
I've added the query params, but I think we should fix the issue in any case.
brunoocasali
force-pushed
the
fix-code-samples
branch
3 times, most recently
from
27199c0 to
dbea512
Compare
brunoocasali
force-pushed
the
fix-code-samples
branch
from
dbea512 to
2216888
Compare
|
bors merge |
|
bors cancel |
|
Canceled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a number of fixes after the latest breaking changes.