Add possibility to show facets with 0 matching documents #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
reviewed
Mar 21, 2022
README.md
Outdated
| ### Placeholder Search | ||
|
|
||
| Placeholders search means showing results even when the search query is empty. By default it is `true`. | ||
| If set to `false`, only when a request is made with at least one character, results will appear. |
There was a problem hiding this comment.
It is maybe came from me but I find this sentence hard to understand
There was a problem hiding this comment.
If set to `false`, results will appear only when a request is made with at least one character.
There was a problem hiding this comment.
When placeholder search is set to
false, no results appears when searching on no characters. For example, if the query is""no results appear.
What do you think?
Co-authored-by: Amélie <alallema@users.noreply.github.com>
|
bors merge |
|
Is this in production yet? This is still a pain point for us. |
|
It is in production, could you open an issue with your specific setup that does not work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #599
Some improvements were done on the readme as well