Skip to content

Remove meilisearch client from public access #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2022
Merged

Remove meilisearch client from public access #708

merged 3 commits into from
Mar 28, 2022

Conversation

bidoubiwa
Copy link
Contributor

Fixes: #578

@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Mar 22, 2022
@bidoubiwa bidoubiwa changed the title Remove meilisearch client from public Remove meilisearch client from public access Mar 22, 2022
@bidoubiwa bidoubiwa force-pushed the remove_meilisearch_client_from_public branch from 45ef4cd to 6592b72 Compare March 22, 2022 17:41
@bidoubiwa bidoubiwa force-pushed the remove_meilisearch_client_from_public branch from 8d93839 to fd137f2 Compare March 23, 2022 10:45
alallema
alallema approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

Base automatically changed from remove_default_finitesearch to main March 28, 2022 11:03
@bidoubiwa
Copy link
Contributor Author

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Mar 28, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit f65d660 into main Mar 28, 2022
@meili-bors meili-bors bot deleted the remove_meilisearch_client_from_public branch March 28, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove public MeiliSearchClient from the InstantMeiliSearchClient
2 participants
@bidoubiwa @alallema