Fix placeholdersearch #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
changed the base branch from
main
to
remove_meilisearch_client_from_public
|
bors merge |
There was a problem hiding this comment.
@bidoubiwa i missed the timing here, but I really like to left some notes 🌮
| expect(searchParams.limit).toBe(0) | ||
| }) | ||
|
|
||
| test('Adapt SearchContext placeholderSearch set to false', () => { |
There was a problem hiding this comment.
This test has the same description as the first one :)
| pagination, | ||
| defaultFacetDistribution, | ||
| placeholderSearch: !options.placeholderSearch, // true by default | ||
| placeholderSearch: options.placeholderSearch !== false, // true by default |
There was a problem hiding this comment.
This option is protected by type? Because if the user add 123, 0 in this option, the option will be true :)
| await meilisearchClient.index('movies').waitForTask(documentsTask.uid) | ||
| }) | ||
|
|
||
| test('Test placeholdersearch set to false', async () => { |
There was a problem hiding this comment.
What about describing what the test should be expecting?
Responds with no hits when placeholderSearch is falsy.
| expect(hits.length).toBe(5) | ||
| }) | ||
|
|
||
| test('Test placeholdersearch set to true', async () => { |
There was a problem hiding this comment.
There is a typo here (the setup use placeholderSearch: false)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #709
placeholderSearchis suppose to not showcase any search result when the query is empty. It now correctly does what it is suppose to do. It is also improved as it will now avoid to do a search request to Meilisearch.