Object constructor for search parameters #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
refactor
skip-changelog
brunoocasali
reviewed
Apr 6, 2022
There was a problem hiding this comment.
@bidoubiwa, I need to understand how typescript works and how we can deal with a legacy OOP/Class oriented style to functional programming.
In general just the naming I think we can iterate over 😄
I left some comments about the code, but in the end, I want to say that is precisely the kind of discussion I would like to have here :)
Congrats on your work!
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to make a more maintainable code the huge function creating the search parameters is replaced by a more modular object creator.
It is made based on the adapter pattern see refactoring guru. With a somewhat similar example in javascript here