-
Notifications
You must be signed in to change notification settings - Fork 95
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
There are several tests in the test suite that test if a value is an instance of object
. In Python everything behind the scenes in an object so these tests are always going to be True. For example isinstance('test', object)
, isinstance(1, object)
, and isinstance({"a": 1}, object
will all return True.
I am assuming the thinking for these tests was object in a javascript context since many are testing what should be something like {"updateId": 1}. In this case the assert would instead be assert isinstance(test_value, dict)
instead of assert isinstance(test_value, object)
bidoubiwa, eskombro and curquiza
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers