Skip to content

Testing isinstance #225

@sanders41

Description

@sanders41

There are several tests in the test suite that test if a value is an instance of object. In Python everything behind the scenes in an object so these tests are always going to be True. For example isinstance('test', object), isinstance(1, object), and isinstance({"a": 1}, object will all return True.

I am assuming the thinking for these tests was object in a javascript context since many are testing what should be something like {"updateId": 1}. In this case the assert would instead be assert isinstance(test_value, dict) instead of assert isinstance(test_value, object)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions