Skip to content

Patching request to guarantee timeout #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2021
Merged

Patching request to guarantee timeout #239

merged 1 commit into from
Mar 20, 2021

Conversation

sanders41
Copy link
Collaborator

Closes #238

bidoubiwa
bidoubiwa approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I can't remember if you suggested mocking in the first iteration but it is indeed the best solution to test this scenario

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa bidoubiwa mentioned this pull request Mar 20, 2021
Closed
@bors
Copy link
Contributor

bors bot commented Mar 20, 2021

Build succeeded:

@bors bors bot merged commit 9a56f4a into meilisearch:main Mar 20, 2021
@bidoubiwa bidoubiwa mentioned this pull request Mar 20, 2021
Closed
@sanders41 sanders41 deleted the timeout_test branch March 20, 2021 22:53
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should find a way to test timeout

2 participants

@sanders41 @bidoubiwa