Skip to content

get_indexes returns a list of Index instance + add raw index methods #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2021
Merged

get_indexes returns a list of Index instance + add raw index methods #261

merged 2 commits into from
May 27, 2021

Conversation

sanders41
Copy link
Collaborator

@bidoubiwa bidoubiwa self-requested a review May 24, 2021 18:58
bidoubiwa added a commit that referenced this pull request May 24, 2021
@bidoubiwa
Update to v0.14.3
28fa29b 
wait for #261
@bidoubiwa bidoubiwa mentioned this pull request May 24, 2021
Merged
bidoubiwa
bidoubiwa suggested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🔥

bidoubiwa
bidoubiwa approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🔥

@bidoubiwa
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request May 25, 2021
@bors @sanders41
Merge #261
b8a9cde 
261: Adding raw index methods r=bidoubiwa a=sanders41

Fixes #258
Relates to meilisearch/integration-guides#120
Relates to meilisearch/integration-guides#121
Relates to meilisearch/integration-guides#122

Co-authored-by: Paul Sanders <psanders1@gmail.com>
@curquiza
Copy link
Member

bors merge-

@bors
Copy link
Contributor

bors bot commented May 25, 2021

Canceled.

@curquiza
Copy link
Member

I canceled the merge because I want to be sure all the integration team is ok with this choice, the related issues in integration guides are not all ready to implement for the moment but they will be really soon 🙂

@curquiza
Copy link
Member

The related issues are now ready to implement!!
Sorry @sanders41 for the delay and thanks again for this PR ❤️

bors merge

@curquiza curquiza added the breaking-change The related changes are breaking for the users label May 27, 2021
@curquiza
Copy link
Member

curquiza commented May 27, 2021 •
edited
Loading

I put the label breaking change as it impacts the usage of the get_indexes method

@bors
Copy link
Contributor

bors bot commented May 27, 2021

Build succeeded:

@bors bors bot merged commit c09d433 into meilisearch:main May 27, 2021
@curquiza curquiza changed the title Adding raw index methods get_indexes returns a list of Index instance + add raw index methods May 27, 2021
@sanders41 sanders41 deleted the raw_index branch May 27, 2021 11:46
bors bot added a commit that referenced this pull request Jun 1, 2021
@bors @bidoubiwa
Merge #262
a20d4c0 
262: Update to v0.15.0 r=bidoubiwa a=bidoubiwa

wait for #261

Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@brunoocasali brunoocasali mentioned this pull request Oct 15, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_index doesn't return the expected information
3 participants
@sanders41 @bidoubiwa @curquiza