Skip to content

Update README.md #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 11, 2021
Merged

Update README.md #339

merged 3 commits into from
Oct 11, 2021

Conversation

mk1107
Copy link
Contributor

@mk1107 mk1107 commented Oct 11, 2021

Issue #338

I have done changes please once review it.

@mk1107 mk1107 mentioned this pull request Oct 11, 2021
Closed
alallema
alallema reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mk1107 for this PR!
It should be ' instead of ". Sorry it wasn't clear

@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Oct 11, 2021
@mk1107
Copy link
Contributor Author

mk1107 commented Oct 11, 2021 •
edited
Loading

In python both " and ' are valid and if you see below all results are in " so I did that in ".
If you then also say I will change that

@alallema
Copy link
Contributor

You are right the both are fine, but the rest of the readme is in ' except the json. So if could change it it would be great!
Thanks

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 11, 2021 •
edited
Loading

changed as u wished please once check.

alallema
alallema reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mk1107, but the json format should be in ". You just have to change like explain in the issue the lines 78 to 80 and add ' around the parameters.

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 11, 2021

changed as u wished please once check.

alallema
alallema approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @mk1107

@mk1107
Copy link
Contributor Author

mk1107 commented Oct 11, 2021

are there any rewards on this repo ??

@alallema alallema linked an issue Oct 11, 2021 that may be closed by this pull request
Add ' around the parameters in README #338
Closed
@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 11, 2021

Build succeeded:

@bors bors bot merged commit 4b3af92 into meilisearch:main Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ' around the parameters in README
2 participants
@mk1107 @alallema