Skip to content

Update code samples #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 7, 2022
Merged

Update code samples #427

merged 12 commits into from
Apr 7, 2022

Conversation

alallema
Copy link
Contributor

No description provided.

@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Apr 5, 2022
@alallema alallema linked an issue Apr 5, 2022 that may be closed by this pull request
Update .code-samples.meilisearch.yaml #426
Closed
7 tasks
@alallema alallema marked this pull request as ready for review April 6, 2022 09:42
@alallema alallema force-pushed the code-samples-update branch from 4595edd to 2e192af Compare April 6, 2022 10:48
@alallema alallema force-pushed the code-samples-update branch from 2e192af to f5f977e Compare April 6, 2022 10:56
bidoubiwa
bidoubiwa suggested changes Apr 6, 2022
View reviewed changes
bidoubiwa
bidoubiwa reviewed Apr 6, 2022
View reviewed changes
@alallema @bidoubiwa
Update .code-samples.meilisearch.yaml
c56da25 
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@alallema alallema requested a review from bidoubiwa April 6, 2022 15:52
bidoubiwa
bidoubiwa previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema @bidoubiwa
Update .code-samples.meilisearch.yaml
531a29e 
Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
@alallema alallema force-pushed the code-samples-update branch from c6227ed to 531a29e Compare April 7, 2022 10:31
@alallema alallema requested a review from bidoubiwa April 7, 2022 10:50
@alallema alallema force-pushed the code-samples-update branch from b451c96 to 9976ef0 Compare April 7, 2022 12:43
bidoubiwa
bidoubiwa reviewed Apr 7, 2022
View reviewed changes
@alallema alallema force-pushed the code-samples-update branch from 9976ef0 to 0a84edc Compare April 7, 2022 13:26
bidoubiwa
bidoubiwa approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥 LGTM 🔥🔥🔥🔥

@alallema
Copy link
Contributor Author

alallema commented Apr 7, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 7, 2022

Build succeeded:

@bors bors bot merged commit 6b07f83 into main Apr 7, 2022
@bors bors bot deleted the code-samples-update branch April 7, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

1 more reviewer

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update .code-samples.meilisearch.yaml

2 participants

@alallema @bidoubiwa