Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mekanism causing crash because of sound handler #5560

Closed
Moistnugger opened this issue Jul 10, 2019 · 3 comments
Closed

Mekanism causing crash because of sound handler #5560

Moistnugger opened this issue Jul 10, 2019 · 3 comments
Labels
bug Fixed in dev
Milestone
9.8.0

Comments

@Moistnugger
Copy link

o guys.. I've been expierencing random crashes and it tells me that the cause is "Mekanism" and "Random things" anyone know what I could do?
https://paste.dimdev.org/heqasinoni.mccrash

err one "workaround/fix" would be in the config for the client section turn enablePlayerSounds to false and I believe that will stop it (as that should stop the sound events that are crashing from ever being fired). From the looks of it, my guess is that sometimes somehow the player it is trying to play the sounds for is null (might happen if a mob has a jetpack unsure, also unsure how the mob would get the jetpack)
pupnewfster added a commit that referenced this issue Jul 10, 2019
@pupnewfster
Fix PlayerSounds sometimes having a null player #5560, also fix flame…
1afc374 
… thrower sounds not actually playing
@pupnewfster pupnewfster added this to the 9.8.0 milestone Jul 10, 2019
pupnewfster added a commit that referenced this issue Jul 16, 2019
@pupnewfster
Fix PlayerSounds sometimes having a null player #5560, also fix flame…
08e29be 
… thrower sounds not actually playing
pupnewfster added a commit that referenced this issue Jul 20, 2019
@pupnewfster
Fix a few issues with sound (#5561)
c5fbabe 
* Fix PlayerSounds sometimes having a null player #5560, also fix flame thrower sounds not actually playing

* Add todo comment and remove extra null check

* Cleanup a couple checks in TickHandler

* Cleanup some more tick handler methods

* Only store EntityPlayer as a WeakReference for sound, and sync flamethrower users

* Fix flamethrower idle sound not playing when first holding a flamethrower client side

* Don't lookup the EntityPlayer object if not needed

* make fade up actually fade
@SnaveSutit
Copy link

SnaveSutit commented Jul 22, 2019 •
edited
Loading

I've been having a similar issue, but conflicting with Immersive Vehicles (MTS). I've been unable to obtain a crash report as it completely freezes my game to the point where task manager has to get involved. I'm going to look though the logs tonight to see if I can find anything that might point towards the exact cause. The sound effects from MTS are also extremely choppy when flying near any mekanism machine blocks

@pupnewfster
Copy link
Member

Not sure as this issue only has to do with the player sounds:

  • Jetpack
  • Gas Mask
  • Flamethrower (doesn't work at all so isn't even a possible cause of the problem)

Later today there will be a release of 9.8.0 which will fix this (as well as the flamethrower). So I recommend also trying it against this version when you experiment later.

@pupnewfster
Copy link
Member

Speaking of which version 9.8.0 was just released and should sync to the twitch client within the next couple hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixed in dev
Projects
None yet
Milestone
9.8.0
Development

No branches or pull requests
3 participants
@pupnewfster @SnaveSutit @Moistnugger