-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Limbo] Sort out the bundling process #1142
Comments
done, the build process willl now generate a I propose to keep the previous/existing |
@obiot should we re-open this? |
yes maybe, I've been working these last 2 days on a bug in the collision system (see here), as soon I'm done wit it, I'll resume the build process update, now that also rollup 3 has been released |
@L1lith finally moved to rollup 3, but it was not that straightforward, and I also had to upgrade to node 19 and add some other workarounds :) I haven't yet (re)added the tree-shaking module, I'll look at it tomorrow, but that will be the last step ! |
@L1lith and we are done I think here ! I kept Maybe we can rename |
adding this one here for reference: https://nodejs.org/api/packages.html#nodejs-packagejson-field-definitions |
@L1lith closing this one |
I was thinking it would be best to ship the full source code that way it can be imported directly without needing to load the whole thing. There might need to be a legacy bundle
Also it relates to this issue as we need to orient the tests around our distributions.
It would also make sense to make a special browser dist where the dependencies point to CDN URLs instead of using NPM package names, that way it can be imported directly in the browser without a bundling step (which would also eliminate the need for tree-shaking all-together when being used this way). We could put this distribution on a CDN too (or put a download on the website or both). We could also look for alternative ways to make a browser distro where the dependencies are included inside without requiring bundling the whole lib into one file
The text was updated successfully, but these errors were encountered: