Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve content width on mobile screens #871

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

rwfeather
Copy link
Contributor

Layout was looking really bad on my phone. Now we completely 0 the margins and go full width on sm screen sizes.

Before:
IMG_1625

After:
IMG_1626

And the code blocks are still successfully overflowing into a horizontal scrollbar rather than off the page

@rwfeather rwfeather requested a review from cjohnhanson as a code owner October 3, 2022 19:42
@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit 38b2a9f
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/633b3b43f1a94f000879e7de
😎 Deploy Preview https://deploy-preview-871--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aaronsteers
Copy link
Contributor

Thanks, @rwfeather - Looks really good.

Can you drop a note here once this merges? Thanks!

@rwfeather rwfeather merged commit 51d4c98 into main Oct 3, 2022
@rwfeather rwfeather deleted the improve-mobile-responsiveness branch October 3, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants