-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] improve github loader #984
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
- Coverage 65.13% 64.34% -0.79%
==========================================
Files 118 118
Lines 4302 4406 +104
==========================================
+ Hits 2802 2835 +33
- Misses 1500 1571 +71 ☔ View full report in Codecov by Sentry. |
} | ||
data.append( | ||
{ | ||
"content": clean_string(content), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to strip the new lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is still needed but feel free to change in the follow up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good generally. Left some minor comments.
@deven298 I am a bit confused with the type as |
Sorry, closed the pull request by mistake. |
@deshraj |
Description
This PR adds functionality to load issues and PR from github repos.
Type of change
How Has This Been Tested?
Checklist:
Maintainer Checklist