New timeout handling to fix issue #52 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We move to a new (yet again!) timeout handling system where we only use one active timer at a time, and track future timeouts / deadlines in our own queue to re-arm the timer. This fixes issue #52. We could use `setMaxListeners` to instead increase the timeout handlers allowed and keep with the existing design, but this approach is O(1) scalable.
|
This seems fine, but because it changes a pretty core part of the request handling, maybe it's best to bump to |
|
Sure, happy to bump to |
alloy
added a commit
to artsy/metaphysics
that referenced
this pull request
Jan 20, 2017
The version we were using had an issue where too many timeout handlers were being defined: memcachier/memjs#86. This lead to many warnings like the following in the production logs: (node:9852) Warning: Possible EventEmitter memory leak detected. 11 timeout listeners added. Use emitter.setMaxListeners() to increase limit The logs also show many `ECONNRESET` and similar errors, which may be related to this: memcachier/memjs#89. According to that thread, however, it seems like version 0.10.0 could also be suffering from issues, although others report it working for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few different people reported issue #52, this commit fixes it.
Basically what would occur is if you ran the following:
You'd get an exception as Node doesn't like you creating more than 11 timeouts by default, and we'd try to create 20. We could increase the number of timeouts allowed (to infinite), but this design seems nicer, to just use one timeout and track deadlines in a queue.
We also bump to version 0.9.2.