Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5247
The recursion was caused by the following:
Clicking on any item in the search results that does not match any regex, for example the future SegWit version address
bc1pfeessrawgf
(prior commit 7d7f9b1) would start a loop that never ends.mempool/frontend/src/app/components/search-form/search-results/search-results.component.ts
Lines 70 to 71 in 0a11680
triggers
mempool/frontend/src/app/components/search-form/search-form.component.ts
Lines 240 to 242 in 0a11680
triggers (because no regex match)
mempool/frontend/src/app/components/search-form/search-form.component.ts
Lines 305 to 307 in 0a11680
triggers
mempool/frontend/src/app/components/search-form/search-results/search-results.component.ts
Lines 38 to 40 in 0a11680
...etc
This PR removes the line that triggers the search back when no regex matches.