Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output ID to transaction info #880

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

softsimon
Copy link
Member

fixes #413

  1. It is now possible to search for TXID with output index, EG: 027fd5be9caaa88939421193e0b28ce388f111a0c32c8df8e2288dac2704c6be:0
  2. The output will be highlighted similar to Liquid unblinding

Screen Shot 2021-10-19 at 23 25 22

3. The arrow links to previous output will include output index in the link.

Screen Shot 2021-10-19 at 23 26 24

Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If (index > 10) then need to expand the "load all" thing like in this TX: https://mempool.ninja/tx/0a96c2ef88437436422f203863d6f293267e773bdc8736fabe559ce31261856f:85

Also probably a good idea to make the arrow icons link to the index

@softsimon softsimon force-pushed the simon/transaction-output-id branch 3 times, most recently from e99f5d3 to 0d37eab Compare October 20, 2021 11:43
Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ 0d37eab
Works great

Copy link
Member

@wiz wiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK @ 1a37c8b
only added semicolon so seems fine to merge

@wiz wiz merged commit a9f4418 into master Oct 20, 2021
@wiz wiz deleted the simon/transaction-output-id branch October 20, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add output ID to transaction info
2 participants