chore(fix): Fix region options not passed when merging options #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This commit does not deserve a change log since it will be bundled in the same release that introduced the feature. Changelog: None Ticket: None Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
|
@alfrunes, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can cherry pick to a given branch or branches with:
|
|
@mender-test-bot start pipeline --fast |
|
Hello 😸 I created a pipeline for you here: Pipeline-657928050 Build Configuration Matrix
|
This commit is a backward compatibility fix that broke with the aws package version bump. Changelog: None Ticket: None Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
|
@mender-test-bot start pipeline --fast |
|
Hello 😸 I created a pipeline for you here: Pipeline-657975316 Build Configuration Matrix
|
kjaskiewiczz
approved these changes
Oct 4, 2022
This is a follow-up fix for Azure blob storage, making the aliases work for environment variables - the built-in viper.RegisterAlias is not a propper configuration alias. In addition, this commit moves the configuration loading logic into the config package. Signed-off-by: Alf-Rune Siqveland <alf.rune@northern.tech>
|
@mender-test-bot start pipeline --fast |
|
@kjaskiewiczz sorry, I discovered another issue. Can you please take a look at the last commit as well? |
|
Hello 😸 I created a pipeline for you here: Pipeline-658038068 Build Configuration Matrix
|
kjaskiewiczz
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This commit does not deserve a change log since it will be bundled in the same release that introduced the feature.
Changelog: None
Ticket: None
Signed-off-by: Alf-Rune Siqveland alf.rune@northern.tech