[WC-3091] Fix issue with not loaded captions in Dropdown sort #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
reviewed
Sep 23, 2025
packages/shared/widget-plugin-sorting/src/react/hocs/withLinkedSortStore.tsx
Outdated
Show resolved
Hide resolved
leonardomendix
previously approved these changes
Sep 29, 2025
gjulivan
dismissed stale reviews from leonardomendix and iobuhov
via
27bec7e
gjulivan
force-pushed
the
dropdown-sort-fix-stale-options
branch
from
ab06506 to
27bec7e
Compare
iobuhov
approved these changes
Sep 30, 2025
samuelreichert
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Widget didn't take captions into account besides first loading. This change makes the caption re-render if they change by observing them.