Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip RAM voltage check? #38

Closed
oida opened this issue Sep 25, 2018 · 3 comments
Closed

Skip RAM voltage check? #38

oida opened this issue Sep 25, 2018 · 3 comments

Comments

@oida
Copy link

oida commented Sep 25, 2018

Hey, I was wondering what this is actually about: https://github.com/merge/skulls/blob/master/x230/x230_before_first_install.sh#L70
Since I was having a quite intense discussion with a friend about that, and if this may be needed at all.
From what we found in the wiki page which is linked in x230/README.md: https://www.coreboot.org/Intel_Native_Raminit#Sandybridge.2FIvybridge
I understood that the RAM voltage can only be adjusted on some Sandybridge/Ivybridge boards, but support for that is not implemented within coreboot, so RAM voltage is always fixed to 1,5V on the X230 and all Sandybridge/Ivybridge boards.
We also did a lookup and understood that PC3 is always 1,5V and all PC3L modules can run with either 1,35V or 1,50V: https://en.wikipedia.org/wiki/DDR3_SDRAM#DDR3L_and_DDR3U_extensions
so both PC3 and PC3L must work in the X230, which will always run with 1,5V.
Am I missing something or can this check be removed alltogether, or at least for the X230? Thanks

@merge
Copy link
Owner

merge commented Sep 26, 2018

All I know is that I've once plugged in a module specified with 1,35V and coreboot wouldn't start. So to me it made sense to add this in order to be safe. If you test this I'll do tests again and we'll see. But as long as it could prevent failure it doesn't hurt to have this check in there I guess.

thanks for reviewing!

@rrrnld rrrnld mentioned this issue Oct 6, 2018
@felixheld
Copy link

By specification DDR3L RAM has to work in 1.5V DDR3 slots; however DDR3 RAM might not work reliably at 1.35V. In general I wouln't trust information in the deprecated coreboot wiki too much.
If a SODIMM that works with the vendor firmware doesn't work with coreboot, it is due to some other bug. IIRC there was some problem with certain memory modules with the timC discovery; in that case trying to apply this patch might resolve the problem: https://review.coreboot.org/c/coreboot/+/23087

@i-c-o-n
Copy link

i-c-o-n commented Jan 1, 2019

I agree with Felix. If a DIMM is failing, it's not about the voltage (unless the DIMM is faulty somehow).

merge added a commit that referenced this issue Jan 7, 2019
This simplifies setup by remove the unneeded RAM voltage checking.

According to the spec, DDR3L RAM has to work using 1.5V, see
https://en.wikipedia.org/wiki/DDR3_SDRAM#DDR3L_and_DDR3U_extensions.
Coreboot simply doesn't always implement changing voltage, which
can never prevent RAM from working though.

Closes #38
@merge merge closed this as completed in 717cf0e Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants