Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(x230): add soic8 image #107

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Conversation

Thrilleratplay
Copy link
Contributor

@jcholsap
Copy link

#3 and #7 should be pulled up to Vcc. It's not just academic either. I replaced an EEPROM on a T430s with a Winbond chip and had to solder #7 to #8. The Micronix chip internally pulls up #7 to Vcc.

@Thrilleratplay
Copy link
Contributor Author

@jcholsap SOIC 8 pinout should have pin 3 as the write protect pin and pin 7 as the suspend serial input. Do you have the data sheet for the model you used?

@jcholsap
Copy link

w25q64fv.pdf

@jcholsap
Copy link

Why all inputs should be connected:
Slow-Floating_CMOS-Inputs.pdf

@jcholsap
Copy link

Page 7 notes that #7 is pulled up internally. This was my scenario whereby my replacement Winbond chip needed an external pull up... Well it was already in circuit and I was in a hurry so I just bridged it which is ok for SPI interfaces.
Macronix-MX25L12835FZ2I-10G-datasheet.pdf

@jcholsap
Copy link

Add if you were to bridge #3 to ground, then it is hardwire write protected until you pull it out of circuit. THere could be a use case for that.

@jcholsap
Copy link

I'm just trying to be thorough because experience has taught me that it's the 10% less probable events that causes 90% of the confusion. Someone is certainly going to program a chip out of circuit, solder it back in, and then "oh, i've bricked my laptop". When in fact it's just a detail of that particular EEPROM and how the engineers implemented it. And it's always good practice to connect all the pins at all times. It just happens that with these SPI EEPROMs you can strap pins directly to Vcc and/or GND.

@Thrilleratplay
Copy link
Contributor Author

Given that the goal of skulls is to simplify the coreboot process, I feel like including this information would be confusing and potentially dangerous to newcomers. However that is a decision for @merge to make.

@jcholsap
Copy link

Reversing your SOIC clip is dangerous and could melt your EEPROM.

@merge
Copy link
Owner

merge commented Oct 18, 2019

as I see this, creating an image in order to improve the docs is one thing/commit - changing the docs and having every pin connected is a different thing/commit/PR.

So the PR looks good to me. I'd like to save some of your discussion here for the future though :) thanks.

@merge merge merged commit 1cde00d into merge:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants