fix: Respect all comments in lastComment validator and comment action #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andekande there are merge conflicts |
andekande
force-pushed
the
fetch-all-comments
branch
from
95ba53f to
38576d5
Compare
|
Conflicts are expected. I'll happily take care of it. One unrelated remark: The latest changes to the build pipeline seem to have broken the Coverage reporting that appeared on the PR as a comment. |
andekande
force-pushed
the
fetch-all-comments
branch
from
38576d5 to
72e0295
Compare
shine2lay
approved these changes
Jun 20, 2024
|
🎉 This PR is included in version 2.19.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub API only returns 30 issue_comments by default. That can be problematic when the bot runs on PRs or Issues with a long discussion thread, since it won't be able to find the lastComment of a human or himself.